search

danielhrisca / asammdf

Fast Python reader and editor for ASAM MDF / MF4 (Measurement Data Format) files
GNU Lesser General Public License v3.0
612 stars 216 forks source link

unnecessary print statement removed #942

Closed morbult closed 6 months ago

morbult commented 8 months ago

This print statement seems unnecessary. It originates from 4e2b2d27af1ed1312fdb4276bf4a80a9fa8e546e but I cant't see the purpose. Could it just be removed?

For me it started to appear just now that I changed my Python environment. Everytime I run Signal.plot I get an error printed (no actual error, just the traceback printed) because the call to gui.plot 4 lines above the print raises an Exception since importing PySide6 fails in my environment. But Signal.plot produces a plot, so no need to show an error I guess.

danielhrisca commented 7 months ago

the style test is failing, you need to run this file to fix the problems https://github.com/danielhrisca/asammdf/blob/development/run_black_and_ruff.bat

morbult commented 6 months ago

Sorry for the delay (and using the master branch) but now I added the changes from running the style checks in development/run_black_and_ruff.bat

morbult commented 6 months ago

Not really sure how to proceed here. Style checks fail because of 

style: commands[1]> ruff check ./src
  src/asammdf/signal.py:8:23: F401 [*] `traceback.format_exc` imported but unused

but ruff doesn't pick up on that when I run locally. I'll remove that import manually.

Regarding the general tests which fails on Ubuntu and Windows in test_PushButton_CreateWindow and test_Plot_ChannelSelection_DragAndDrop_fromPlot_toPlot, I don't see how that is related to my PR.

morbult commented 6 months ago

Style should be fixed now

danielhrisca commented 6 months ago

Thanks!