danielhrisca / asammdf

Fast Python reader and editor for ASAM MDF / MF4 (Measurement Data Format) files
GNU Lesser General Public License v3.0
611 stars 216 forks source link

Warn and relax global j1939 if non-extended IDs present #997

Closed hacklint closed 2 months ago

hacklint commented 3 months ago

I had a DBC file containing one message with non-extended ID. asammdf refused to accept that and threw an exception even if the rest of the file was OK. I think warning in this case may be a less drastic approach - the suggested change allows me to run without modifying either asammdf locally or my incoming data, while still passing the tests.

Speaking of tests - it seems to me that running the GUI tests on a large screen (3840 x 2160) places the gui window in the lower right part of the screen, but it seems the cursor is placed farther and farther to "north-west", ie up and left - and after a while leaving the window which stops the test sequence. Manually moving it back makes tests continue, but the behaviour is repeated, Running on a "standard" sized screen does not seem to behave like this.