danielhstahl / black_scholes_rust

Rust for black scholes
https://danielhstahl.github.io/black_scholes_rust/dev/bench/
22 stars 8 forks source link

chore: Update dependencies, and migrate code to 2021 edition #13

Closed Uzaaft closed 2 years ago

Uzaaft commented 2 years ago

The title pretty much says it all. Just some maintenance for this crate.

coveralls commented 2 years ago

Pull Request Test Coverage Report for Build 2985218226


Changes Missing Coverage Covered Lines Changed/Added Lines %
src/lib.rs 2 6 33.33%
<!-- Total: 2 6 33.33% -->
Totals Coverage Status
Change from base Build 1802547170: -0.4%
Covered Lines: 331
Relevant Lines: 348

💛 - Coveralls
danielhstahl commented 2 years ago

Looks like its still 2018?

Uzaaft commented 2 years ago

Ops, had to revert it for a moment. Give me 2s and I'll fix that

Uzaaft commented 2 years ago

My bad. Should be 2021 now

Uzaaft commented 2 years ago

2 tests seems to fail due to some floating point stuff. Screen below. Perhaps I could go ahead and reduce the number of decimals we use in the test if it's alright with you danielhstahl

image image

List over tests:

image
danielhstahl commented 2 years ago

Test seem to be passing in GHA?

Uzaaft commented 2 years ago

peculiar....very peculiar