danieljfarrell / pvtrace

Optical ray tracing for luminescent materials and spectral converter photovoltaic devices
Other
97 stars 94 forks source link

Import TraceError in dieletric.py missing #25

Closed dcambie closed 4 years ago

dcambie commented 4 years ago

Again thanks for the great code of pvtrace!

dieletric.py raises a TraceError at line 96 without importing it.

(+ minor typos)

danieljfarrell commented 4 years ago

Hi,

I wrote a comment on the other pull request. I will update master soon with a huge refactor. So don't bother submitting any changes.

If you are curious pull from redesign/materials branch.

danieljfarrell commented 4 years ago

Hi Dario,

I'm going to close this because it's related to the master branch which will all soon be superseded. But I did copy over the typos.! Thanks.