search

danieljfarrell / pvtrace

Optical ray tracing for luminescent materials and spectral converter photovoltaic devices
Other
98 stars 94 forks source link

Example code to show the visualization error in nested cylinders #26

Closed dcambie closed 4 years ago

dcambie commented 4 years ago

Ray-tracing and visualization are not coherent one with the other.

See image below: the two cylinder share the same axis for the tracing algorithm, but not for the visualization Viz_error

dcambie commented 4 years ago

Sorry, this should have been an issue and not a pull request...

I'll look further into it now and hopefully I'll be able to provide a proper merge request later

danieljfarrell commented 4 years ago

Hi!

I’ve had a major refactor of the code on another branch. It’s basically ready to go but have not yet made a release because I need to update all the documentation. For this reason, don’t invest too much time I fixing anything because I’m going to drop that onto master and it may fix these issues. Sorry this came at a bad time. I should have updated the readme to warn people. Was not expecting any contributions.

dcambie commented 4 years ago

Ah, ok great! No problem :)

danieljfarrell commented 4 years ago

Well thanks for quick fix it really is appreciated!

I just verified this bug occurs on the redesign/materials branch too. My hunch is that I forgot to apply the parent's transformation. Normally this was the identity matrix as so I never found this bug before!

danieljfarrell commented 4 years ago

Going to close this now as I've just fixed it in the main development branch redesign/materials.

danieljfarrell commented 4 years ago

Pressed wrong button