search

danieljfarrell / pvtrace

Optical ray tracing for luminescent materials and spectral converter photovoltaic devices
Other
98 stars 94 forks source link

Changing Behavior of point source #3

Closed lukasHD closed 8 years ago

lukasHD commented 10 years ago

Hey thanks for the really usefull Tracer.

I found an error in the creation of the point source. I fixed it in the straight forward way, feel free to merge it in the main branch.

Additonally and to speed up the execution I changed the commit to the database to %100 as originaly indicated by your comment.

Cheers Lukas

danieljfarrell commented 10 years ago

Yes I think you are correct, thanks. To speed thing up can you provide a test that shows the improvement works. For example, a plot of the different distributions before and after for a quarter hemisphere. This is the kind of test I would do before including the code myself, but I won't be able to do this for a while.

danieljfarrell commented 8 years ago

Two years later (sorry).