search

danieljfarrell / pvtrace

Optical ray tracing for luminescent materials and spectral converter photovoltaic devices
Other
97 stars 94 forks source link

Add support to Py3.8 thanks to meshcat 0.1.1 #51

Closed dcambie closed 3 years ago

dcambie commented 3 years ago

Thanks to Meshcat>0.1.1 supporting Py38+

Actually, pvtrace also works well with Python 3.9 on linux now, so maybe python_requires could be <3.10. However, there are currently no xxhash wheels available for Windows (issue ifduyue/python-xxhash#43) nor it is available on conda and it needs to be compiled, so not easy for random users...

danieljfarrell commented 3 years ago

Great changes, thanks for updating everything!

I think there are some skipif decorators on the rendering tests for Windows. Do they now pass?

danieljfarrell commented 3 years ago

Thanks @dcambie ! I've merged into develop! I'll get the remaining tests to pass.

dcambie commented 3 years ago

Great changes, thanks for updating everything!

I think there are some skipif decorators on the rendering tests for Windows. Do they now pass?

Good question, I'll check those! P.S. Sorry for targeting master and not develop, next time I'll do it right:)

danieljfarrell commented 3 years ago

No problem, I logged in with my phone and could not see an option to change, but it was obvious when using the desktop site!

danieljfarrell commented 3 years ago

I think I did it! Test pass, one weird issue, but I think it is solved in the CLI branch so will just wait for that.

If you have anything else you want to add it can target here, https://github.com/danieljfarrell/pvtrace/tree/release/2.1.7 otherwise, I'll merge this to master and make a new release in a few days.