Code Lab Feedback - Githubissues

danieljhogan commented 9 years ago

Hey @chrisvfritz, Here is my JavaScript intro joke button thing. This one was a bit challenging to get the hang of, because I got confused about how to make a button (I did Google 'javascript make a button and got a HTML code to do one). After some mentor help, I got it figured out though.

It's hosted here and meets the following project criteria:

[x] Include a button that will display a silly, but tasteful joke in an alert when clicked
[x] Return no errors (warnings are OK) when the HTML is uploaded to the W3C Markup Validation Service
[x] Return no errors or warnings when the JavaScript is pasted into JavaScript Lint

chrisvfritz commented 9 years ago

Thanks for the feedback @danieljhogan! We've now added a link with an example of an HTML button to that project criterion. :smiley: And this code looks great, so :shipit:. :tada:

danieljhogan commented 9 years ago

Great! Thank you. On Nov 3, 2015 11:59 AM, "Chris Fritz" notifications@github.com wrote:

Thanks for the feedback @danieljhogan https://github.com/danieljhogan! We've now added a link with an example of an HTML button to that project criterion. [image: :smiley:] And this code looks great, so [image: :shipit:]. [image: :tada:]

— Reply to this email directly or view it on GitHub https://github.com/danieljhogan/codelab-js-intro/issues/1#issuecomment-153417235 .

danieljhogan / codelab-js-intro

Code Lab Feedback #1