danieljjh / oppia

Automatically exported from code.google.com/p/oppia
Apache License 2.0
0 stars 0 forks source link

Code review request for gadget-ui-editor #787

Open GoogleCodeExporter opened 9 years ago

GoogleCodeExporter commented 9 years ago
Branch name: gadgets-ui-editor

Link to the relevant commit(s):
https://code.google.com/p/oppia/source/detail?r=9f51c7dfc1dfd629069a477776c22310
a5bffea6&name=gadget-ui-editor#

Purpose of code changes on this branch:
- Backend refactor to make panel names available in FE on initiation.
- First functional gadget editor UI saves from FE to BE and loads in learner 
view.

When reviewing my code changes, please focus on:
- 3 inline questions in EditorServices.js, a few things don't seem "right" yet, 
but /w time zone difference it seemed better to post for feedback than sit on 
them overnight.
- Acknowledging BE/FE tests are needed for all new methods/services. I'm hoping 
we can work out what the correct implementation looks like on a few of these 
open questions so apt tests can be written. (e.g. where/how to convert 
customizationArgs from FE to BE)
- Also note: I squashed the last 2 commits for easier review including Vishal's 
latest changes and a commit I had local only, but it appears a few changes have 
already been reviewed.

After the review, I'll merge this branch into: Nothing yet. We still have a few 
big TODOs to resolve and tests to add, but getting closer! Really excited at 
progress in the last 24 hours with the new editor UI saving an advice bar 
that's then visible in the learner view. :-)

Original issue reported on code.google.com by anu...@google.com on 27 May 2015 at 10:30