danieljjh / oppia

Automatically exported from code.google.com/p/oppia
Apache License 2.0
0 stars 0 forks source link

Code review request #794

Open GoogleCodeExporter opened 9 years ago

GoogleCodeExporter commented 9 years ago
Branch name: upgrade-protractor

Link to the relevant commit(s): 
https://code.google.com/p/oppia/source/detail?r=4d7ce84a9c5388cbb24aef0593c88f90
a6d2aa23&name=upgrade-protractor#

Purpose of code changes on this branch: Upgrade protractor version to 2.1.0 and 
parallelize the tests so that they run faster.

When reviewing my code changes, please focus on:
- Ben: code and functionality
- Allan: could you please do a test run of the integration tests on this branch 
on your machine, and let me know if everything works fine?
- Kevin: could you please do a test run of the integration tests on this branch 
on your machine, and let me know if everything works fine?

Note: the way to do a test run is as follows:

    git checkout upgrade-protractor
    git pull origin upgrade-protractor
    bash scripts/run_integration_tests.sh

With any luck, this will end with something like:

   [launcher] chrome #1-2 passed
   [launcher] chrome #1-3 passed
   [launcher] chrome #1-1 passed
   [launcher] chrome #1-5 passed
   [launcher] chrome #1-4 passed
   [launcher] chrome #1-0 passed

After the review, I'll merge this branch into: develop

Original issue reported on code.google.com by s...@seanlip.org on 30 May 2015 at 8:06