danieljjh / oppia

Automatically exported from code.google.com/p/oppia
Apache License 2.0
0 stars 0 forks source link

Code review request #799

Closed GoogleCodeExporter closed 9 years ago

GoogleCodeExporter commented 9 years ago
Branch name:
default-content-field-for-end-exp

Link to the relevant commit(s):
https://code.google.com/p/oppia/source/detail?r=3cf8f6bdc8d9caea13ddf9e1d628a221
2298a241&name=default-content-field-for-end-exp#

https://code.google.com/p/oppia/source/detail?name=default-content-field-for-end
-exp&r=e9d91033d46af91ee3cd7d08412d77c9de94c51e

Purpose of code changes on this branch:
To remove the 'Congratulations, you are finished!' text from showing up for 
every exploration by default and, instead, relying on the value text of a state 
with an EndExploration for sending that message. It also defaults said text to 
the same congratulations message by default when an EndExploration is selected 
for a state.

When reviewing my code changes, please focus on:
everything

After the review, I'll merge this branch into: 
create-exp-migration-system-combined

If you want to test it, I recommend using the merged branch:

https://code.google.com/p/oppia/source/detail?name=default-content-field-for-end
-exp&r=8961ae5d25cf8531e6c6963960fb39ed34470ae2

Original issue reported on code.google.com by bhenn...@google.com on 2 Jun 2015 at 6:29

GoogleCodeExporter commented 9 years ago
Please instead review this commit:

https://code.google.com/p/oppia/source/detail?r=df14c9ed593ccc11d2be3a599483091e
3b8c979e&name=create-exp-migration-system-combined

Per our discussion in person, the above is the combined deltas of the 
default-content-for-end-exp patched into create-exp-migration-system-combined. 
I have made some other minor aesthetic changes per style guide violations I 
wasn't aware of when I wrote the code originally.

Original comment by bhenn...@google.com on 2 Jun 2015 at 8:59

GoogleCodeExporter commented 9 years ago

Original comment by s...@google.com on 2 Jun 2015 at 9:15