marker issues

[karlglazebrook]

Markers seem to be different from pgplot

e.g. test2.p in perl-pgplot

Marker 14 in pgpoint() should produce a 'plus' symbol, but instead produces a circle. Have not checked the rest.

Also the default marker size seems to be a lot smaller than in regular pgplot. It needs to be approximately doubled.

This may seem to be a minor point, but can make for a lot of regineering of plots.

[haavee]

Hi Karl,

I've started to look at this; I have noticed a similar issue. I attach screenshots from pgdemo1 example 7, where I have magnified the symbols (by re-reverting my proposed change of a fixed 0.2 scaling factor - https://github.com/danieljprice/giza/pull/2#issuecomment-418925368 and https://github.com/danieljprice/giza/commit/68e782b1a8fc6bba98ccd220b65103c68e4b3649) temporarily to be able to see the details of the symbols being drawn.

This might be a timely point to start/continue this discussion

I don't think this is a minor point; I think it is quite crucial.

[karlglazebrook]

I don’t think it is a minor point either - the symbol sizes should be approximately the same, by default, in order to not have to tediously fiddle lots of old code

Karl

On 2 Nov 2018, at 8:24 pm, Harro Verkouter notifications@github.com wrote:

Hi Karl,

I've started to look at this; I have noticed a similar issue. I attach screenshots from pgdemo1 example 7, where I have magnified the symbols (by re-reverting my proposed change of a fixed 0.2 scaling factor - #2 (comment) https://github.com/danieljprice/giza/pull/2#issuecomment-418925368 and 68e782b https://github.com/danieljprice/giza/commit/68e782b1a8fc6bba98ccd220b65103c68e4b3649) temporarily to be able to see the details of the symbols being drawn.

This might be a timely point to start/continue this discussion https://github.com/danieljprice/giza/pull/2#issuecomment-419269737 I don't think this is a minor point; I think it is quite crucial. https://user-images.githubusercontent.com/14309703/47906361-5c95b100-de89-11e8-9b5f-bc8b11ca3a68.png https://user-images.githubusercontent.com/14309703/47906381-6c14fa00-de89-11e8-9959-3c303ef29b8d.png — You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/danieljprice/giza/issues/5#issuecomment-435319665, or mute the thread https://github.com/notifications/unsubscribe-auth/AOnymi3TKSq4VePClhqIXsKj9DnTS1Hxks5urA9GgaJpZM4XyTuu.

[karlglazebrook]

Here is a comparison of markers in giza (top) vs pgplot (bottom)

https://www.dropbox.com/s/y8fz1me3nb5rgbh/gizavspgplot.png?dl=0

Marker 21 is one I use quite commonly and the change messes up a lot of plots - and ought to be easy to fix? The rest not so much, 19 seems very different

[haavee]

Busy going through these, so far four symbols done, stay tuned

[karlglazebrook]

This looks good with v1.1