it's easier to spot genuine errors if there are no warnings emitted when compiling phantom. Ideally the aim should be to keep the master branch `clean', i.e. compiling with no warnings where possible
in principle this could be enforced in the build actions by adding the -Werror flag, but this should not be on in the Makefile by default as blocks the compilation of otherwise perfectly acceptable code while developing/debugging
progress towards this involves:
eliminating all existing compiler warnings on the master branch
ensuring that phantom can be compiled successfully with -Werror, at least with fortran
checking this across all builds
eventually enforcing this in the actions (maybe as a non-mandatory check?)
One issue is that some warnings are hard to suppress or are caused by internal compiler issues, e.g. warnings about unused variables with .ubound etc on allocatable arrays
danieljprice
commented
1 year ago
it's easier to spot genuine errors if there are no warnings emitted when compiling phantom. Ideally the aim should be to keep the master branch `clean', i.e. compiling with no warnings where possible
in principle this could be enforced in the build actions by adding the -Werror flag, but this should not be on in the Makefile by default as blocks the compilation of otherwise perfectly acceptable code while developing/debugging
progress towards this involves:
One issue is that some warnings are hard to suppress or are caused by internal compiler issues, e.g. warnings about unused variables with .ubound etc on allocatable arrays