danieljprice / phantom

Phantom Smoothed Particle Hydrodynamics and Magnetohydrodynamics code
https://phantomsph.github.io
Other
103 stars 224 forks source link

Enable adding 4 sink particles to a disc setup #355

Closed amenafaruqi closed 1 year ago

amenafaruqi commented 1 year ago

Type of PR:

Modification to the disc setup type to allow the following configurations:

Description:

The last 2 rows of this table summarise the added configurations:

No. of Sinks Disc Type Disc Centred On
1 circumstellar origin
2 circumprimary primary star
2 circumsecondary secondary star
2 circumbinary origin
3 circumtriple origin
3 circumbinary first hierarchical level secondary
4 circumbinary first hierarchical level secondary

Testing:

Did you run the bots?

danieljprice commented 1 year ago

looks good to me, thanks Amena!