danieljprice / phantom

Phantom Smoothed Particle Hydrodynamics and Magnetohydrodynamics code
https://phantomsph.github.io
Other
108 stars 239 forks source link

bug fix gw inspiral #367

Closed martinatoscani closed 1 year ago

martinatoscani commented 1 year ago

Type of PR: Bug fix

Description: star was exploding/ wrong substitution of gas particles among primary and secondary. Also bug fix with dtsinksink=0 when there is only one sink particle

Testing: relax a polytrope with SETUP=star, use moddump_sinkbinary to place star in orbit around massive BH to see inspiral (iexternalforce=14)

Did you run the bots? no