danieljprice / phantom

Phantom Smoothed Particle Hydrodynamics and Magnetohydrodynamics code
https://phantomsph.github.io
Other
108 stars 239 forks source link

(hfact) remove remaining hardwired hfact=1.2; replace with hfact=hfact_default #381

Closed danieljprice closed 1 year ago

danieljprice commented 1 year ago

Type of PR: other

Description: the default setting of hfact=1.2 is ok for the cubic spline but not if a different kernel is employed. Hence we should not have any hardwired hfact=1.2 statements in the code. This replaces those remaining with hfact=hfact_default where hfact_default is a parameter in the top of the corresponding kernel module.

Testing: compiled phantomanalysis and moddump with the amended files

Did you run the bots? no