danieljprice / phantom

Phantom Smoothed Particle Hydrodynamics and Magnetohydrodynamics code
https://phantomsph.github.io
Other
103 stars 224 forks source link

No warnings #387

Closed danieljprice closed 1 year ago

danieljprice commented 1 year ago

Type of PR: other

Description: Implementation of #349 this change causes the GitHub actions to fail if any compiler warnings are present when compiling with gfortran by compiling with the -Werror flag which turns warnings into errors. This change is needed to prevent new compiler warnings being introduced on the master branch.

The first task is to see what fails, and then slowly fix everything. If this P-R ever passes, it will be possible to compile every possible SETUP of phantom with no compiler warnings!

Testing: Can at least compile a number of setups I have tested with -Werror. The actual testing will take place in the GitHub actions workflow itself as I expect a bunch of things to fail, for which we then have to clean up all the warnings :)

UPDATE: nearly everything should now compile successfully with -Werror

Did you run the bots? yes