Dynamic Boundaries; clump finding analysis; cloud-cloud collision setup

[jameswurster]

Type of PR: New numerical algorithms New analysis routines

Description: This PR contains all the algorithms required for Wurster & Bonnell (2023). This includes -Dynamic boundaries -a new clump-finding algorithm -a new setup routine to collide two clouds

Testing: Extensive testing prior to performing the study of Wurster & Bonnell (2023) ran the testsuite for good measure.

Did you run the bots? yes

[jameswurster]

@danieljprice , it looks like the failures are due to the workflow not being able to download the proper libraries or compilers...

[jameswurster]

@danieljprice , I hope that this merge didn't mess up anything. The delay in accepting my PR caused a merge conflict when I wanted to update something, so I followed the instructions on the screen. While I think all of your changes have been kept, I hope that some of my tests & temporary code has not been merged as well. Edit: Due to stashing, everything should be correct, except possibly the Authors file.

[jameswurster]

Not sure if the failed checks are a result of my merge or the pipeline.

[jameswurster]

This looks like a pipeline failure where it could not connect to required sites.

[danieljprice]

sorry my fault for the delay here, I was trying to push some other things through the pipeline that I knew would give some conflicts...

[danieljprice]

but some of the build failures are genuine: we no longer allow compiler warnings in phantom on master, so it's complaining about a few warnings being added (e.g. in moddump), which need to be cleaned up:

Error: ‘fdg_inclean$’ may be used uninitialized in this function [-Werror=maybe-uninitialized]

[jameswurster]

@danieljprice as requested, dynamic boundaries are now in their own module.

[danieljprice]

PS: to fix the conflicts in the authors file:

cd phantom/scripts
./bots.sh --only authors --commit