danieljprice / phantom

Phantom Smoothed Particle Hydrodynamics and Magnetohydrodynamics code
https://phantomsph.github.io
Other
103 stars 223 forks source link

Damping bcs #404

Closed danieljprice closed 1 year ago

danieljprice commented 1 year ago

Type of PR: Bug fix

Description: The damping timescale in the disc damping boundary conditions was incorrectly scaled to divide by the damp parameter rather than multiply. This is now checked via a unit test.

Testing: Added unit tests in test_damping.f90 that are now part of the test suite

Did you run the bots? no

Did you update relevant documentation in the docs directory? no