Fixed issue in mod dump_tidal about not varying black hole mass

danieljprice / phantom

Phantom Smoothed Particle Hydrodynamics and Magnetohydrodynamics code

https://phantomsph.github.io

Other

103 stars 223 forks source link

Fixed issue in mod dump_tidal about not varying black hole mass #409

Closed msha0023 closed 1 year ago

msha0023 commented 1 year ago

Type of PR: Bug fix / modification to existing code

Description: The black hole mass can change now in moddump_tidal.f90. Additionally, fixed the binning method in analysis_kepler.f90 + edited utils_orbits.f90 + analysis_kepler can calculate the velocities of remnants now in Newtonian physics.

Did you run the bots? no

Did you update relevant documentation in the docs directory? no

danieljprice commented 1 year ago

thanks Megha, this fixes #408 . The build failures are just unused variable warnings coming from utils_orbits.f90: