search

danieljprice / phantom

Phantom Smoothed Particle Hydrodynamics and Magnetohydrodynamics code
https://phantomsph.github.io
Other
103 stars 223 forks source link

GitHub actions workflow to check phantom+mcfost #412

Closed danieljprice closed 1 year ago

danieljprice commented 1 year ago

Type of PR: continuous integration testing, closes #379

Description: this is a GitHub action to compile phantom and link it against MCFOST, as needed for live phantom+mcfost simulations the idea is to check if the API gets broken for whatever reason (could either be at the phantom or on the mcfost end).

Testing: Will be tested in the actions workflow

Did you run the bots? no

Did you update relevant documentation in the docs directory? yes, the action follows recommended installation procedure for homebrew installation of mcfost in the mcfost help page

danieljprice commented 1 year ago

the failure here is due to #341 and needs to be fixed by pull request to MCFOST.

Update: P-R opened at https://github.com/cpinte/mcfost/pull/58