Description:
Cleanup of the setup procedure for tidal disruption events in General Relativity. Previously this required compiling with SETUP=grstar and then moddump using moddump_tidal.f90
Now, setup_grtde calls the new general set_star procedure to setup and relax a star. To avoid the need to switch metrics we simply set M=0 in the Kerr or Schwarzschild metric during relaxation, effectively giving a Minkowski metric during the stellar relaxation procedure
I also corrected an issue where we had set ireconav = 1 by default in the .in file for GR simulations, which is problematic if anything gets too close to the black hole. Hence the default setting is now ireconav=-1. This fixes #333
Testing:
1000 particle GR tidal disruption event with polytrope works out-of-the-box
Did you run the bots? yes
Did you update relevant documentation in the docs directory? not yet
Type of PR: improved setup procedure
Description: Cleanup of the setup procedure for tidal disruption events in General Relativity. Previously this required compiling with SETUP=grstar and then moddump using moddump_tidal.f90
Now, setup_grtde calls the new general set_star procedure to setup and relax a star. To avoid the need to switch metrics we simply set M=0 in the Kerr or Schwarzschild metric during relaxation, effectively giving a Minkowski metric during the stellar relaxation procedure
I also corrected an issue where we had set ireconav = 1 by default in the .in file for GR simulations, which is problematic if anything gets too close to the black hole. Hence the default setting is now ireconav=-1. This fixes #333
Testing: 1000 particle GR tidal disruption event with polytrope works out-of-the-box
Did you run the bots? yes
Did you update relevant documentation in the docs directory? not yet