danieljprice / phantom

Phantom Smoothed Particle Hydrodynamics and Magnetohydrodynamics code
https://phantomsph.github.io
Other
103 stars 223 forks source link

restartable relaxation process for stars #414 #417

Closed danieljprice closed 1 year ago

danieljprice commented 1 year ago

Type of PR: enhanced functionality implementing #414

Description: If phantomsetup is interrupted half way through a stellar relaxation, or did not fully converge, the process can be restarted by simply running phantomsetup again. Similarly, running phantomsetup will look for matching snapshots from previous relaxation runs and will not repeat the procedure if the star is already relaxed

This P-R also fixes a couple of memory allocation errors encountered when running phantomsetup with DEBUG=yes.

To prevent these from reoccurring phantomsetup is now always compiled with DEBUG=yes in the GitHub actions tests

this required a bunch of things to be fixed in a bunch of different setup routines

Testing: running phantomsetup using SETUP=binary as described in the docs

Did you run the bots? yes

Did you update relevant documentation in the docs directory? yes