Type of PR:
new warning + star mass and radii now always specified in solar radii
Description:
read mass and radius for polytropic stars in solar mass and solar radii rather than code units, this is particularly helpful for GR
warns the user about stars being too small for weak field gravity to be valid
fix a small bug where total mass in particles was not computed in GR code
For example, if one naively chooses default values M=R=1 in code units when using the GR code this produces a star smaller than its Schwarzschild radius, giving errors like the following when you run phantom:
WARNING! cons2primsolver [in step_extern_sph_gr (a)]: enthalpy did not converge on particle 1
WARNING! cons2primsolver [in step_extern_sph_gr (a)]: enthalpy did not converge on particle 836
Testing:
~/phantom/scripts/writemake.sh grstar > Makefile
make setup
make
./phantomsetup star
./phantomsetup star
./phantom star
Did you run the bots? no
Did you update relevant documentation in the docs directory? no
Type of PR: new warning + star mass and radii now always specified in solar radii
Description:
For example, if one naively chooses default values M=R=1 in code units when using the GR code this produces a star smaller than its Schwarzschild radius, giving errors like the following when you run phantom:
Testing:
Did you run the bots? no
Did you update relevant documentation in the docs directory? no