danieljprice / phantom

Phantom Smoothed Particle Hydrodynamics and Magnetohydrodynamics code
https://phantomsph.github.io
Other
103 stars 223 forks source link

Compute total enclosed mass in self-gravitating disc initial conditions #427

Closed crislong closed 1 year ago

crislong commented 1 year ago

Type of PR: Bug fix

Description: There is a bug when setting up dust in self-gravitating discs where the enclosed mass is not computed correctly.

The new code computes enclosed dust and gas mass to take into account the disc self gravity in the velocity initialisation

Testing: make SETUP=dustyisosgdisc setup ./phantomsetup disc check that velocities of gas and dust particles are the same

Did you run the bots? no

Did you update relevant documentation in the docs directory? no