search

danieljprice / phantom

Phantom Smoothed Particle Hydrodynamics and Magnetohydrodynamics code
https://phantomsph.github.io
Other
103 stars 223 forks source link

AOCC compiler fix #437

Closed Fitz-Hu closed 1 year ago

Fitz-Hu commented 1 year ago

Type of PR: Bug fix

Description: Add flag when using aocc so it fixes the bug automatically

Testing: ran make test

Did you run the bots? no

Did you update relevant documentation in the docs directory? no

danieljprice commented 1 year ago

fix looks good, I will merge for now but eventually would be good to eliminate the need for this. It is related to #46, we should not need procedure pointers to switch the file format as we can deprecate the direct-write hdf5 option now that Sarracen exists and replace it with an hdf5 conversion utility