Bug Fix - Githubissues

danieljprice / phantom

Phantom Smoothed Particle Hydrodynamics and Magnetohydrodynamics code

https://phantomsph.github.io

Other

103 stars 223 forks source link

Bug Fix #440

Closed lsiess closed 1 year ago

lsiess commented 1 year ago

Type of PR: Bug fix

Description:

Fix critical typo in set_star.f90
in set_star, ask to provide the sink luminosity
in checksetup, check that sink luminosity is defined if radiation pressure on dust is to be used.
Improve CE.rst
remane routine nucleation --> calc_nucleation to avoid conflict with a variable name

Testing: OK

Did you run the bots? no but minor commit

Did you update relevant documentation in the docs directory? yes

danieljprice commented 1 year ago

failure here is in "make analysis" with SETUP=star, giving:

../src/utils/analysis_common_envelope.f90 This name has already been assigned a data type.   [RHOPART]
                                   omega_orb,kappai,kappat,kappar,pgas,mu,entropyi,rhopart,&