setup asteroidwind not working

[becnealon]

Asteroidwind setup appears not to work as it should, if run with defaults it

• does not inject any particles
• does not reset the mass of the particles from the injection rate

To fix, need to at least:

• set massoftype(igas) during setup appropriately from the mass injection rate
• fix the calculation of how many particles to inject in each timestep

[becnealon]

Follow up:

• massoftype(igas) is easily fixed by putting the mdot option back into the setup file and adding utime
• mdot_type is currently not used, so only constant mass injection rate is available (prefer the 1/r^2 option)
• default parameters are contradictory: mass1=0.7 but iexternalforce=11, during setup mass1 is correctly reset to be 1. so that LT can be used. It would be ideal if everything else was rescaled to accommodate this so the final calculation is equivalent to a mass1=0.7 calculation instead.

[danieljprice]

please have a look at #463, I believe this now has the correct behaviour and more or less along the lines of the comment. We definitely should not be trying to set the particle mass in the injection routine itself, we need to make a reasonable guess as to the desired resolution based on a desired tmax and some kind of mdot

• I'm unclear what the last issue about the mass1=1 is, this is only related to the setting of code units

• mdot_type is being used correctly as far as I can see

• I also noticed the timestep here seems very small, I think this could be fixed by choosing a larger injection radius (I think we used a "true" asteroid radius)

[becnealon]

Thanks for taking a look at this. I think the problem with mass1=1.0 is that the setup allows for different options. From memory there was no warning to say that your choice had been overridden or that the masses were rescaled accordingly which would be the better option. I could have missed it.

---

From: Daniel Price @.> Sent: Monday, 23 October 2023 6:35 AM To: danieljprice/phantom @.> Cc: Nealon, Rebecca @.>; Author @.> Subject: Re: [danieljprice/phantom] setup asteroidwind not working (Issue #463)

please have a look at #463https://github.com/danieljprice/phantom/issues/463, I believe this now has the correct behaviour and more or less along the lines of the comment. We definitely should not be trying to set the particle mass in the injection routine itself, we need to make a reasonable guess as to the desired resolution based on a desired tmax and some kind of mdot

I'm unclear what the last issue about the mass1=1 is, this is only related to the setting of code units

I also noticed the timestep here seems very small, I think this could be fixed by choosing a larger injection radius (I think we used a "true" asteroid radius)

— Reply to this email directly, view it on GitHubhttps://github.com/danieljprice/phantom/issues/463#issuecomment-1774467103, or unsubscribehttps://github.com/notifications/unsubscribe-auth/AMWRPUHBPTMAW3JI6BLVRHLYAX633AVCNFSM6AAAAAA3VHIMIOVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTONZUGQ3DOMJQGM. You are receiving this because you authored the thread.Message ID: @.***>