Set units for shock setup

danieljprice / phantom

Phantom Smoothed Particle Hydrodynamics and Magnetohydrodynamics code

https://phantomsph.github.io

Other

94 stars 223 forks source link

Set units for shock setup #481

Closed themikelau closed 8 months ago

themikelau commented 9 months ago

Interactive setup now prompts for mass and length units
Units now written into and read from setup file

themikelau commented 9 months ago

@danieljprice Some of the tests involving integration of binary orbit in the testptmass module seem to have failed because they exceeded a maximum runtime of the workflow. I don't see how the changes I have made would have caused this. Any ideas on how to get the tests to pass?

themikelau commented 9 months ago

@danieljprice Thanks for the review. Indeed I added this for running a radiation-dominated shock. I will add if (do_radiation) around my changes.

danieljprice commented 8 months ago

I have raised an issue on the slow actions, #484 , looking into it but this is currently blocking merge (I have rerun all tests and same issue). Affecting both currently open pull requests, so it's nothing from the proposed merges, either something from a previous merge or something changed on the actions runners...