danieljprice / phantom

Phantom Smoothed Particle Hydrodynamics and Magnetohydrodynamics code
https://phantomsph.github.io
Other
94 stars 223 forks source link

fix slow test suite issue #484 + minor cleanups #485

Closed danieljprice closed 8 months ago

danieljprice commented 8 months ago

Type of PR: cleanup / fix issue #484

Description: The ultimate cause of #484 causing timeouts in the test suite is that we oversubscribe the threads available with MPI+openMP. Hence we now only use 2 openMP threads when running with 4 MPI threads to check the hybrid parallelisation in the test suite.

Testing: On my laptop, 4 mpi + 4 openMP takes 330s for a test that takes 15s with 4 mpi + 2 openMP threads.

Did you run the bots? yes

Did you update relevant documentation in the docs directory? no