danieljprice / phantom

Phantom Smoothed Particle Hydrodynamics and Magnetohydrodynamics code
https://phantomsph.github.io
Other
94 stars 223 forks source link

cooling benchmark + cooling prescriptions #488

Open danieljprice opened 8 months ago

danieljprice commented 8 months ago

we need decent unit tests for cooling modules, ideally comparing against analytic solutions e.g. cooling shock problem from Creasey+2011

with these it should be possible to reduce the options for the cooling method (explicit, implicit, exact) and also whether cooling is done in step or force, into ONE "best" option.

We also have overlapping modules for optically thin cooling physics, with some in radiation_implicit.f90, some in cooling_ism.f90 and some in cooling_functions.f90 which nominally all do some of the same things