search

danieljprice / phantom

Phantom Smoothed Particle Hydrodynamics and Magnetohydrodynamics code
https://phantomsph.github.io
Other
103 stars 230 forks source link

Porosity evolution module in Phantom #521

Closed StephaneMichoulier closed 5 months ago

StephaneMichoulier commented 6 months ago

Type of PR: new physics

Description: The porosity module incorporates a porosity evolution model (porosity.f90) that is coupled with the dust growth module. It includes routines to simulate the evolution of porosity during growth, bouncing, fragmentation, with or without compaction, and rotational disruption. The growth module has been modified to accommodate porosity (ds/dt -> dm/dt), where grain size is now grain mass in the dust growth module. Setup and moddump have been modified in consequence.

If you have questions or if you want to modify things, feel free to do it.

Testing: Run multiple simulations for the physics. Test the .setup and .in files when initializing a simulation, as well as the moddump. Run the bot to test other modules to ensure nothing has been broken.

Did you run the bots? yes

Did you update relevant documentation in the docs directory? no

danieljprice commented 6 months ago

thanks Stephane!! Some of the failures are just unused variable warnings (we enforce no warnings on the master branch using -Werror), but there are also some failures in test_growth. Seems like there is also a build failure in initial.f90...

StephaneMichoulier commented 6 months ago

Hi Dan, I will have a look at this failures tomorrow. I run a simulation from scratch and ran the standard test suite without problem. But I am not really surprised that something has been broken during the merge.Stéphane Michoulier Le 25 mars 2024 à 22:12, Daniel Price @.***> a écrit : thanks Stephane!! Some of the failures are just unused variable warnings (we enforce no warnings on the master branch using -Werror), but there are also some failures in test_growth. Seems like there is also a build failure in initial.f90...

—Reply to this email directly, view it on GitHub, or unsubscribe.You are receiving this because you authored the thread.Message ID: @.***>

danieljprice commented 5 months ago

all fixed and merged, thanks Stephane!