search

danieljprice / phantom

Phantom Smoothed Particle Hydrodynamics and Magnetohydrodynamics code
https://phantomsph.github.io
Other
103 stars 230 forks source link

Add the option to integrate ptmass with 4th order scheme (FSI) #523

Closed Yrisch closed 5 months ago

Yrisch commented 6 months ago

Type of PR: New integration method

Description: Add new 4th order integration schemes for point mass evolution. At this moment, The FSI and PEFRL are implemented. Only the gravitational interactions are taken into account. The PEFRL is certainly not well suited for Phantom ( due to backward step). To extend the FSI to all other interactions, it is needed to compute the gradient term for each of them in the middle kick phase. cf : Chin (2007a) 10.1103/PhysRevE.75.036701

Testing: To test these methods, I reused the galcen setup without gas injection. Then the system of point masses is integrated during a short period and a check on the energy and angular momentum conservation is performed. A little test with 2 point masses is also done to check if the evolution correspond to a keplerian motion.

Did you run the bots? no

Did you update relevant documentation in the docs directory? no

Yrisch commented 6 months ago

something wrong appends with the quintic kernel module... There is no new grad kernel