danieljprice / phantom

Phantom Smoothed Particle Hydrodynamics and Magnetohydrodynamics code
https://phantomsph.github.io
Other
103 stars 230 forks source link

(build) add aocc installation #532

Open themikelau opened 5 months ago

themikelau commented 5 months ago

Type of PR: Bug fix / new physics / modification to existing code / other

Description: Give a short description of the change.

Testing: Describe how you have tested the change

Did you run the bots? yes/no

Did you update relevant documentation in the docs directory? yes/no

danieljprice commented 5 months ago

Thanks for this Mike!

themikelau commented 5 months ago

Thanks for the clarification, @danieljprice. Good to know the test is successfully failing. I will first start with a replacement of findloc. I think it can be replaced in-line using other intrinsic functions like minloc or maxloc, without having to write new subroutines. This is worth doing since findloc hasn't been used in other places, and it is desirable to quickly implement an aocc build test before we push more aocc compiler errors.