Open themikelau opened 5 months ago
Thanks for this Mike!
the failure is a Fortran 2008 command (findloc) that is used in set_heirarchical_utils. This also breaks very old versions of gfortran... the workaround would be to write our own subroutine with equivalent functionality, but it seems stupid to make our own routine to reimplement a command that is already in the language...
there is also one known "missing feature" in aocc to do with default initialisation of the procedure pointers for readwrite_dump, which are currently worked around with an #AOCC ifdef, this may cause some build failures in utilities (moddump etc) where the procedure pointers are not explicitly set (by a call to init_readwrite_dumps). Given Sarracen now exists and there are a bunch of problems maintaining the hdf5 format (#46, #161) this stuff is ripe for an overhaul (e.g. deprecate hdf5 functionality and just provide a phantom2hdf5 converter, see #46)
Thanks for the clarification, @danieljprice. Good to know the test is successfully failing. I will first start with a replacement of findloc. I think it can be replaced in-line using other intrinsic functions like minloc or maxloc, without having to write new subroutines. This is worth doing since findloc hasn't been used in other places, and it is desirable to quickly implement an aocc build test before we push more aocc compiler errors.
Type of PR: Bug fix / new physics / modification to existing code / other
Description: Give a short description of the change.
Testing: Describe how you have tested the change
Did you run the bots? yes/no
Did you update relevant documentation in the docs directory? yes/no