Description:
Fixed problems running the Chinese Coin problem from Chin & Chen (2005) as in the phantom paper. The main issue that if one sets mass1 not equal to 1 in the input file with the binary external force (iexternalforce=3) then this was not read from the input file. Also evaluation of the external force was accidentally turned off if there was only one sink particle in the simulation
Also added a few more things to the format bot (OPEN->open, CLOSE->close, TRIM->trim and a few other things)
Testing:
Now implemented in the test suite, can be run with
rm phantomtest && make phantomtest && ./phantomtest coin
Did you run the bots? yes
Did you update relevant documentation in the docs directory? no
Type of PR: Bug fix
Description: Fixed problems running the Chinese Coin problem from Chin & Chen (2005) as in the phantom paper. The main issue that if one sets mass1 not equal to 1 in the input file with the binary external force (iexternalforce=3) then this was not read from the input file. Also evaluation of the external force was accidentally turned off if there was only one sink particle in the simulation
Also added a few more things to the format bot (OPEN->open, CLOSE->close, TRIM->trim and a few other things)
Testing: Now implemented in the test suite, can be run with
Did you run the bots? yes
Did you update relevant documentation in the docs directory? no