patch rad_accel_ptmass to be used with FSI

danieljprice / phantom

Phantom Smoothed Particle Hydrodynamics and Magnetohydrodynamics code

https://phantomsph.github.io

Other

94 stars 210 forks source link

patch rad_accel_ptmass to be used with FSI #539

Closed Yrisch closed 2 months ago

Yrisch commented 2 months ago

Type of PR: Bug fix, fixes #538

Description: Patch the rad_accel_ptmass routine to be correctly used with the new FSI scheme.

Testing:

Did you run the bots? no

Did you update relevant documentation in the docs directory? no

danieljprice commented 2 months ago

this fix is pretty horrible, can we understand why it doesn't work with the acceleration computed inside the get_force routine? I would strongly prefer it to stay there if possible...

Yrisch commented 2 months ago

It's already the case. I also agree that this part should stay in the get_force routine. The point was on where it was in this routine. Sorry for the misleading. I badly explained myself in #538.

danieljprice commented 2 months ago

sorry I think I misunderstood the change here. I added a fix to the mcfost build failure...