search

danieljprice / phantom

Phantom Smoothed Particle Hydrodynamics and Magnetohydrodynamics code
https://phantomsph.github.io
Other
110 stars 244 forks source link

Slow down method and few fixes on the new star formation prescription #583

Closed Yrisch closed 2 months ago

Yrisch commented 3 months ago

Type of PR: new physics

Description: Slow down method during subgroups integration. This method slows down the inner motion of weakly perturbed binaries in subgroups to relax constraints on the time step. It is still possible to follow secular evolution of this binaries without integrating their real fast motion. We loose the orbital phase but the computational gain is significant. See Mikkola and Aarseth (1996) and Wang et al. (2020) for more details.

Testing: This new feature has been tested using the setup hierarchical reproducing tests done in Wang et al. (2020)...

Did you run the bots? yes

Did you update relevant documentation in the docs directory? no

danieljprice commented 3 months ago

this looks ok to merge. Main question is, how would you know if this is broken in the code?

What we really need here to keep this from being broken is an automated unit test, for example could we repeat some of the tests in Wang et al. (2020) as part of the test suite...?

Yrisch commented 3 months ago

Yes, you right. I will work on it !

Yrisch commented 3 months ago

After a lot of fixes and fine tuning, the test should be almost ready. I checked manually the results and it's perfect. I'm finishing automatic checks and It should be good to go !

Yrisch commented 3 months ago

I think everything is fine now. The only failing seems to be a failed download...