danieljprice / phantom

Phantom Smoothed Particle Hydrodynamics and Magnetohydrodynamics code
https://phantomsph.github.io
Other
110 stars 244 forks source link

Update to analysis_common_envelope #591

Closed themikelau closed 3 weeks ago

themikelau commented 2 months ago

It is time to update this analysis module.

Changes to analysis_common_envelope:

Changes to other parts of Phantom:

themikelau commented 2 months ago

The test suite caught a bug with the cons2prim test. There was an issue because I have lumped some changes to entropy calculation in this pull request. Namely, I have ensured that any temperature solving uses the gas constant, Rg, instead of kb_on_mh. Mixing the two constants causes a discrepancy great enough to fail the cons2prim tests. But I forgot to change this in the temperature solving in get_p_from_rho_s. This has been fixed now. Can @Fitz-Hu check if these changes are correct?

danieljprice commented 2 months ago

See comment on splash PR, would be better to use .cols file which is an existing splash feature

danieljprice commented 2 months ago

Also the cons2prim stuff should be pretty well unit tested so happy to approve that