search

danieljprice / splash

SPLASH is an interactive visualisation and plotting tool using kernel interpolation, mainly used for Smoothed Particle Hydrodynamics simulations
http://users.monash.edu.au/~dprice/splash
GNU General Public License v2.0
54 stars 41 forks source link

splash reader for phantom-hdf5 files #25

Open danieljprice opened 4 years ago

danieljprice commented 4 years ago

this is needed, some work sitting in pull request

dliptai commented 3 years ago

submitted pull request #42 to merge updated hdf5-phantom branch into master.

Before approving pull request, it should be checked that reading phantom hdf5 dumps returns the same arrays as reading the phantom binary dump. e.g. pxyzu from GR is currently not being read

danieljprice commented 3 years ago

see comments on #42, this code needs to be rewritten in c consistent with the other hdf5 readers in splash, and also needs to be written in a way that does not hard wire the dataset names in the hdf5 reader, so it does not need ongoing maintenance any time a new quantity is written by phantom. Sorry for not being clearer on requirements here in the first place.