danieljprice / splash

SPLASH is an interactive visualisation and plotting tool using kernel interpolation, mainly used for Smoothed Particle Hydrodynamics simulations
https://splash-viz.readthedocs.io
GNU General Public License v2.0
55 stars 43 forks source link

bug: impossible to color the particles on swiftsim #47

Closed Francyrad closed 2 years ago

Francyrad commented 3 years ago

Dear Professor Daniel Price

On Swiftsim simulations, it's impossible to color a set of particles and follow them, as you can see from these 2 snapshots, advancing in the simulation will result in a kind of color bug

Schermata da 2021-03-07 15-14-32 Schermata da 2021-03-07 15-14-35 Schermata da 2021-03-07 15-14-38 Schermata da 2021-03-07 15-14-40

I also attach some snapshots of the simulation in a zip file. I hope you can solve...

Best Regards and Thank you!

Francesco snapsfordaniel.zip

danieljprice commented 3 years ago

I think this is because the particle id is not read/used from SWIFT snapshots to re-order the particles. I can take a look but it may require a bit of work. Snapshots are helpful, thanks.

Francyrad commented 3 years ago

Thank you professor to work on that! Actually the 2 planets have a core and a mantle of 2 different materials, and there are a lot available on swiftsim..

I also opened an issue the 2 Feb about the command splash calc tracks, it do the calculations, but it doesn't produce the tracks-123.out file on Phantom, StarSmasher and SwiftSim... Let us know and thank you!

Francesco

Francyrad commented 2 years ago

Dear professor Price. The bug is still present in the actual version of SPLASH. I forgot to attach you some hdf5 snaps. I hope that the bug can be fixed... -Francesco

https://drive.google.com/drive/folders/1kc4OHVzMwGS9CN4wJXT4ZAmTmay7jLge?usp=sharing

Francyrad commented 2 years ago

It works perfectly now. Thank you!