danieljprice / splash

SPLASH is an interactive visualisation and plotting tool using kernel interpolation, mainly used for Smoothed Particle Hydrodynamics simulations
https://splash-viz.readthedocs.io
GNU General Public License v2.0
55 stars 43 forks source link

'make SYSTEM=gfortran' fails (undefined reference to 'giza_axis') #74

Open wolfram-schmidt opened 10 months ago

wolfram-schmidt commented 10 months ago

Hi,

after installing giza commit 72d3703 in /usr/local, I attempted to compile splash commit 7cd8892 from source. However,

make SYSTEM=gfortran

throws the following errors when linking:

/usr/bin/ld: giza-fortran.o: in function '__giza_MOD_giza_intern_tick_f2c': giza-fortran.F90:(.text+0x3fed): undefined reference to 'giza_tick' /usr/bin/ld: giza-fortran.o: in function '__giza_MOD_giza_intern_axis_f2c': giza-fortran.F90:(.text+0x4194): undefined reference to 'giza_axis'

The linker runs with option -L/usr/local/lib -lgiza, which is the correct path:

ls /usr/local/lib/libgiza* /usr/local/lib/libgiza.a /usr/local/lib/libgiza.la /usr/local/lib/libgiza.so /usr/local/lib/libgiza.so.0 /usr/local/lib/libgiza.so.0.1.1

Any suggestions how to fix this?

Thanks, Wolfram

danieljprice commented 10 months ago

Hi Wolfram, thanks for flagging this. It's due to a version mismatch in the linked version of giza, would suggest to delete the libgiza* files in /usr/local and reinstall giza to the latest version.

alternatively, you can also install a local copy of giza with splash using "make withgiza SYSTEM=gfortran" with a copy of giza checked out as a subdirectory of splash

wolfram-schmidt commented 10 months ago

Hi Daniel, for my installation I used giza commit 72d3703 (Nov 30, 2023), which is the most recent commit on github. So I don't understand what you mean with "reinstalling giza to the latest version".

wolfram-schmidt commented 10 months ago

Same problem with fresh clones of splash and giza and using the make withgiza variant.