search

danieljprice / splash

SPLASH is an interactive visualisation and plotting tool using kernel interpolation, mainly used for Smoothed Particle Hydrodynamics simulations
https://splash-viz.readthedocs.io
GNU General Public License v2.0
55 stars 43 forks source link

Correct spelling errors in tree. Seen using Debian's 'lintian' package. #88

Closed kathenas closed 2 months ago

kathenas commented 2 months ago

Hi,

My name is Phil Wyett, I am the new primary maintainer of splash in Debian under the umbrella of the Debian Astronomy Team.

A small initial merge request to assist this upstream project.

Correct spelling errors in tree. Seen using Debian's 'lintian' package.

I hope we will collaborate in the future to make sure the best splash is delivered to users.

Regards

Phil

danieljprice commented 2 months ago

Hi Phil,

Thanks for the PR. What would be great here is to hook up the Debian repo to the splash release workflow (in .github/workflows/). For example this workflow automatically updates the homebrew package when I push a release and it would be great for the Ubuntu package to do the same.

A wider problem is a lack of unit /integration testing in splash. Tests of format readers would be an easy one to implement, I have some ideas here for a test harness but it slips down the priority list (and a bit tricky because to run the tests the actions would need to download a bunch of files). In practice my testing is "eat your own dogfood" in that we use bleeding edge splash regularly in the group so tend to spot problems quickly.

Would welcome any suggestions/help here.

Best wishes,

Daniel