danielkleebinder / md3-for-ionic

Customizable material design 3 (material you) for Ionic applications.
MIT License
9 stars 0 forks source link

No support for dark mode #1

Open benmod opened 9 months ago

benmod commented 9 months ago

How to reproduce:

Expected behaviour:

Current behaviour:

Daniel-Mendes commented 9 months ago

Just change in theme\specs\theme.dark.css:

body.dark {}

to

@media (prefers-color-scheme: dark) {
   body {}
}
danielkleebinder commented 9 months ago

@benmod Thank you for this issue! @Daniel-Mendes Thank you for your answer!

Please note that the component style overrides are only a small little hobby project of mine. This tool should just generate the MD3 CSS tokens. That's its primary purpose. It should provide you with all the tokens that are listed in the official Material Design 3 guidelines. However, it would be great if we could extend it to the point where we are fully compliant though!

Daniel-Mendes commented 9 months ago

You should add a kitchen sink demo, so we could check the current state and help improve the md3 design.

Maybe fork: https://github.com/ionic-team/docs-demo

Edit: I forked and added md3-for-ionic in the demo: https://github.com/Daniel-Mendes/docs-demo-main

Examples:

Screenshot of konsta ui dialog component: image

wdcossey commented 7 months ago

@Daniel-Mendes I forked (your fork) and deployed it to Cloudflare Pages.

https://docs-demo-main.pages.dev/

PS: If you open that on an iOS device it'll automatically use to iOS mode

To force it to MD go here https://docs-demo-main.pages.dev/?ionic:mode=md