search

danielkrizian / rChartsDygraphs

An `rCharts` extension. Run `dygraphs` from R - interactive visualizations of time series using JavaScript and HTML canvas. See: http://dygraphs.com/ and
http://rcharts.io/
9 stars 10 forks source link

Fixes for RStudio internal browser preview #13

Closed przmv closed 10 years ago

przmv commented 10 years ago

RStudio uses slightly old rendering engine based on WebKit, so it needs some improvements to be done in the JavaScript code to overcome its limitations.

This PR provides the following fixes:

  1. Lo-Dash compatibility build is used (it works with both «new» and «old» environments)
  2. Date.parse() «polyfill» for working with ISO 8601 dates (introduced in EcmaScript 5.1)

With these fixes applied I successfully run ohlc-trades.R example in my RStudio:

rstudio-canvas-annotations

So, this PR fixes the following issues:

danielkrizian commented 10 years ago

Thank you Petr, you are truly an expert! In addition to using this patch, I can send a message to RStudio team asking about their plans with Webkit or feel free to let them know. Good find.