search

danielkrizian / rChartsDygraphs

An `rCharts` extension. Run `dygraphs` from R - interactive visualizations of time series using JavaScript and HTML canvas. See: http://dygraphs.com/ and
http://rcharts.io/
9 stars 10 forks source link

change getPayload to remove dependency on rCharts dimple_layer #20

Closed timelyportfolio closed 10 years ago

timelyportfolio commented 10 years ago

I forgot that the only change required to remove the dependency on rCharts dimple_layer branch was to change getPayload to use toJSON2 for params here. Sorry this took me so long to realize. Please test on your end to confirm this works and resolves #18.

ramnathv commented 10 years ago

This is good. I was wondering why things were not working for me. I am wondering if this is an rCharts wide change I should be making. The only reason I was cautious was to ensure that toJSON2 does not introduce other issues.

danielkrizian commented 10 years ago

couldn't merge pull request automatically for some reason as indicated by GitHub autodetector, so I did manually. Examples tested and work. README install instructions changed to `install_github("rCharts", "ramnathv"). Thanks