search

daniellandau / switcher

Gnome Shell extension to switch windows quickly by typing
GNU General Public License v3.0
352 stars 43 forks source link

Control panel and other stuff #127

Closed daniellandau closed 3 years ago

daniellandau commented 3 years ago

@goodwillcoding do you want to take another look at this? This code seems to work fine for me on X11, but on Wayland the settings panels don't come up at all.

PHLAK commented 3 years ago

Thanks for the change to enable Ctrl+Enter to launch a new instance. I pulled down this code and tested it and it seems to launch a new instance as expected. However, if I open the swither and select an app that's not already running and press Ctrl+Enter the switcher stays on screen (and I can keep launching new instances with Ctrl+Enter). I'd expect the switcher to disappear instead.

daniellandau commented 3 years ago

That's been a feature for a long time already to allow opening multiple apps quickly.

PHLAK commented 3 years ago

Maybe that should use a different key combination now so it doesn't conflict with the new behavior of Ctrl+Enter. Maybe switch it to Alt+Enter or Shift+Enter? Or even make these configurable?

daniellandau commented 3 years ago

Please check the new commit. This behavior (ctrl+enter on either windows or apps opens a new window and keeps the switcher active) matches quite closely what the overview does. I think we are closing in on a good design, which wouldn't be the case without your input!

daniellandau commented 3 years ago

Now this works for me in both X11 and Wayland sessions. I'll read through the code with fresh eyes after some time still and any testing is also appreciated.

Fixes https://github.com/daniellandau/switcher/issues/84