search

daniellandau / switcher

Gnome Shell extension to switch windows quickly by typing
GNU General Public License v3.0
352 stars 43 forks source link

Badly placed on two-monitor setup #131

Closed andrewazores closed 3 years ago

andrewazores commented 3 years ago

Screenshot from 2021-02-09 10-05-47

In this screenshot, I have a Firefox window open taking up all of my primary/left monitor in a landscape orientation. The image of a road going through hills is my wallpaper, which is shown on a secondary monitor to the right in a portrait orientation. There is some kind of graphical artifact also displayed in some buffer space around the Firefox window on the left monitor - I'm not sure the exact cause of this.

The Switcher overlay appears positioned correctly left-right centered on the primary display, but quite high up. I am only able to see the bottom 4 entries of the 10 when summoned in app launcher mode, for example. The top of this monitor is delimited by the GNOME top bar which is visible just above the Firefox window.

I have verified that this still occurs with the exact same behaviour when all other GNOME Shell Extensions are disabled.

I am running Fedora 33 / GNOME 3.38.2 and in Xorg.

andrewazores commented 3 years ago

86 is somewhat related.

mr-smith2 commented 3 years ago

When running 3 monitors the UI crosses over monitors. My center (primary) monitor is 4k and both side monitors are 1920x1080. Configured with "Show switcher on active display" turned on.

  1. When focus is in window on left monitor, switcher shows correctly on left display.
  2. When focus is in window on middle monitor, switcher shows on right side of left monitor. And overflows into the middle monitor. It looks like the coordinates are correct but is displayed relative to the left monitor instead of the middle monitor.
  3. When focus is in window on right monitor, switcher appears on the left display. I am guessing it is seeing the coordinates are invalid and defaulting to displaying on the first monitor.

If I position the left and right monitors to be aligned at the bottom (i.e. the display settings have the two smaller monitors lined up at the bottom of the 4k monitor) then the switcher UI is invisible. It is positioned above the location of the left monitor.

See attached screenshots to clarify what I mean by top and bottom monitor positioning.

Monitors positioned at top Monitors positioned at bottom

I also notice that resized configuration box stretches the toggle buttons. Toggles stretched

daniellandau commented 3 years ago

The version in master (and soon to be on extensions.gnome.org, after review there) has better positioning code, but I'm not sure if it fixes either of the issues raised here. It very well might. Please report back if/when you have a chance to test the new code. I can also get access to a 4K monitor at some point, but I don't use one regularly.

mr-smith2 commented 3 years ago

Hi @daniellandau. I can confirm the problem is fixed in my scenario. And BTW, thank you for including install instructions in your README.md. I had installed your extension using extensions.gnome.org and wasn't aware of how to install gnome extensions.

The issue where I show toggle buttons being stretched is not fixed. Interestingly, it only happens on the 4k monitor. If I resize the settings window to larger than the vertical 1080 and then move it to the 1920x1080 monitor then I do see the toggles stretched. So you should be able to reproduce by setting the window height to 2160.

daniellandau commented 3 years ago

I tested now with a vertical monitor too and it was working properly.

andrewazores commented 3 years ago

I have just returned back to using the machine I was on when I reported this issue. I've updated the extension through extensions.gnome.org and it's now properly placing the popup for me. Thanks @daniellandau !