search

daniellandau / switcher

Gnome Shell extension to switch windows quickly by typing
GNU General Public License v3.0
352 stars 43 forks source link

Chinese input method support #75

Closed nlpsuge closed 4 years ago

nlpsuge commented 5 years ago

When type with Chinese input method(ibus-rime-1.3.0), press Enter just go to the first window directly. But I want letters should be shown in Switcher.

A workaround: press Shift or switch to English input method before typing any character.

daniellandau commented 5 years ago

Hmm. I want Switcher to work with Chinese, but I need to look into how the input method works a bit before I can estimate how easy/hard that is. Does the normal Gnome Shell overview search work as expected?

nlpsuge commented 5 years ago

Yes, Gnome Shell overview works as expected. I can input letter(s) into search box by pressing Enter with Chinese input method.

By the way, another Gnome extension named Todo.txt(https://extensions.gnome.org/extension/570/todotxt/) has the same issue too, when I try to modify an item.

daniellandau commented 5 years ago

So I can find two errors:

  1. When hitting enter after some letters, the English letters should be input to the text field, list should be filtered and no app should be activated
  2. When selecting Chinese characters with mouse, the list is not updated, but is only updated after hitting another key, for example the space bar. Hitting a number to select a Chinese character works as expected.

Can you confirm that these are the issues? Are there any other that you have found?

I don't have a fix for these yet, but knowing what the issue is and being able to reproduce it is already a good start.

nlpsuge commented 5 years ago

Yes, I can confirm that those two are issues.

No, I only found the first one error, and you found the second. I will notice during using Switcher.

You are so careful, thanks.

daniellandau commented 5 years ago

I'm leaving problem number 2. go unsolved for now, as that doesn't work in Shell overview either (in fact, works even worse there). I already have a version sitting in review at extensions.gnome.org, so I'll submit this fix after that one gets through. Meanwhile you can get the latest version with the directions in the README.

nlpsuge commented 4 years ago

Hi @daniellandau ,

I think this issue has been reoccurred. Should I reopen it or report a new one?

daniellandau commented 4 years ago

Does chinese input method work for you in the normal Gnome Shell overview now? For me that is broken too as I try it.

nlpsuge commented 4 years ago

No, it does not work either in the Overview.

And cannot type into any Chinese characters both in the Overview and Switcher.

Maybe is this a issue linked to Gnome Shell itself?

daniellandau commented 4 years ago

This seems to be an issue with gnome shell, please report it to https://gitlab.gnome.org/GNOME/gnome-shell/

Let's keep this issue open until it's fixed, but at the moment I can't do much about it.

nlpsuge commented 4 years ago

Ok. I'll report this issue later. Thanks.

nlpsuge commented 4 years ago

Here is a related issue and I add a comment there: https://gitlab.gnome.org/GNOME/mutter/-/issues/1413#note_908581

nlpsuge commented 4 years ago

This issue has been fixed in recent updates.