search

daniellawrence / graphitesend

Easy python bindings to write to Carbon ( Re-write of carbonclient)
Apache License 2.0
137 stars 42 forks source link

Allow python3 encode/decodes #70

Open daubers opened 7 years ago

daubers commented 7 years ago

This was stopping me from using this on a py3 only system. A simple check to see if the message is a python 3 byte object and then handle it appropriately

coveralls commented 7 years ago

Coverage Status

Coverage increased (+0.09%) to 93.426% when pulling bbc03312e1f793013eadd9da9996bbd1dcfead8a on daubers:py3encodes into 262852575f6bc47cb039c1ddebd47a1c62fa4775 on daniellawrence:master.

Shir0kamii commented 7 years ago

@daubers What was the error you had with the current implementation ? We have a test suite for Python 3 so I'm a bit surprised that it doesn't work for you, even on py3 only systems

coveralls commented 7 years ago

Coverage Status

Coverage increased (+0.09%) to 93.426% when pulling 0a4fb004add4ae74a2df25b2d86c5a2fae7f8bf5 on daubers:py3encodes into 6f84c56ad4e7594cf36b0c3d4aeaa86b4dd3ef06 on daniellawrence:master.