search

daniellek12 / Reading7

1 stars 0 forks source link

private profile #87

Closed AdvaBitan21 closed 4 years ago

rotemsamuel commented 4 years ago

Added base code. One can change his profile's privacy via toggle swithch inside profile fragment. When trying to access private profile, content will be shown iff the profile is non- private or the viewer already follow the private profile.

Still need to make some visibility changes (better UI and on place refresh) and implement follow requests mechanism.

AdvaBitan21 commented 4 years ago

Great! I think we should also add the ability to choose which content the user wants to share. for example, I want to share one shelf in my profile(the books I have already read), but not my wish list. what do you think?

rotemsamuel commented 4 years ago

Are you reffering only for shelves or for other kinds of content? Anyway, I think that for now we should stick to the original idea of reveal or hide the entire content as Instagram does, and maybe add this feature in future sprints (not because it's complicated but because it will add a lot of fields to are DB)

AdvaBitan21 commented 4 years ago

ammm I talked about shelves, and I'm pretty sure we talked about this idea as a group. and why not adding an array field to the DB ?

rotemsamuel commented 4 years ago

Done 🎉